Skip to content

docs: remove base readme obsolete information #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

docs: remove base readme obsolete information #1072

merged 1 commit into from
May 29, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

base/README.md contains outdated information:

  • base images do not install the latest versions of NPM & Yarn
    • npm is bundled with Node.js. Often the bundled version of npm lags behind the latest version of npm.
    • Yarn is not the latest version. It is the frozen Yarn v1 Classic version defined in factory/.env (currently 1.22.19). The latest Yarn Modern version is 4.2.2.
  • The sections referring to Node.js are discussing legacy Cypress versions and versions of Node.js which are no longer under support

Change

Remove the outdated information from base/README.md

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

Sign in to view
@MikeMcC399 MikeMcC399 force-pushed the base-readme-outdated branch from dfb6803 to 0d84398 Compare May 29, 2024 08:15
@MikeMcC399

This comment was marked as outdated.

Sign in to view
@MikeMcC399 MikeMcC399 force-pushed the base-readme-outdated branch from 0d84398 to 03e0b5c Compare May 29, 2024 08:35
@MikeMcC399 MikeMcC399 self-assigned this May 29, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 29, 2024 08:54
jennifer-shehane
jennifer-shehane approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jennifer-shehane jennifer-shehane merged commit 78b5799 into cypress-io:master May 29, 2024
31 checks passed
@MikeMcC399 MikeMcC399 deleted the base-readme-outdated branch May 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees

@MikeMcC399 MikeMcC399

Labels
documentation 📝
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcC399 @cypress-app-bot @jennifer-shehane